Skip to content

♻️ Merge Placement and Routing into Layout Synthesis #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 31, 2025
Merged

♻️ Merge Placement and Routing into Layout Synthesis #713

merged 18 commits into from
Jul 31, 2025

Conversation

@ystade
Copy link
Collaborator

@ystade ystade commented Jul 29, 2025 •
edited
Loading

Description

This PR prepares the structure of the neutral atom compiler for upcoming projects, where the placement and routing stage will be performed in one step. This one step will be called layout synthesis. For the current implementation that splits both steps into separate stages, it provides a PlaceAndRouteSynthesizer that allows building a LayoutSynthesizer from separate Placement and Routing steps.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@github-project-automation github-project-automation bot moved this to In Progress in MQT Compilation Jul 29, 2025
@ystade ystade self-assigned this Jul 29, 2025
@ystade ystade added c++ Anything related to C++ code refactor Anything related to code refactoring labels Jul 29, 2025
@ystade ystade added this to the Neutral Atom Compilation milestone Jul 29, 2025
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ystade ystade added the minor Changes leading to a minor version increase label Jul 29, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 29, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 29, 2025
View reviewed changes
@ystade ystade marked this pull request as ready for review July 29, 2025 10:33
@ystade ystade requested a review from burgholzer July 29, 2025 10:33
burgholzer
burgholzer approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very clean. I only have some nitpick comments which should be addressed easily.

@ystade ystade enabled auto-merge (squash) July 29, 2025 12:08
@ystade ystade merged commit fb60e20 into main Jul 31, 2025
34 checks passed
@ystade ystade deleted the joined-placer-router branch July 31, 2025 14:50
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Compilation Jul 31, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burgholzer burgholzer burgholzer approved these changes

Assignees

@ystade ystade

Labels

c++ Anything related to C++ code minor Changes leading to a minor version increase refactor Anything related to code refactoring

Projects

None yet

Milestone

Neutral Atom Compilation

Development

Successfully merging this pull request may close these issues.

4 participants

@ystade @burgholzer @denialhaag